-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider skipped checks as meeting Maestro policy #3636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, should we try this?
@mmitche see my comment in Teams about ignored checks and then merge this if you still feel like we should do this |
Rolled-out by #3972 |
This doesn't appear to have worked as expected: |
It may be that the check is actually neutral and not skipped |
I guess we need to check the GitHub API response to see what is the actual value it returns |
The GraphQL gives me this:
|
@mmitche are we worried that |
Last time we did try to change the neutral state: #2997 |
Any more news here? Still affecting SDK PR checks. |
Release Note Category
Release Note Description
Consider skipped checks as meeting Maestro policy