Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider skipped checks as meeting Maestro policy #3636

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jun 14, 2024

Release Note Category

  • Feature changes/additions
  • Bug fixes
  • Internal Infrastructure Improvements

Release Note Description

Consider skipped checks as meeting Maestro policy

Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we try this?

@premun
Copy link
Member

premun commented Jun 17, 2024

@mmitche see my comment in Teams about ignored checks and then merge this if you still feel like we should do this

@premun premun merged commit f8cd36c into dotnet:main Sep 17, 2024
9 checks passed
@oleksandr-didyk
Copy link
Contributor

Rolled-out by #3972

@mmitche
Copy link
Member Author

mmitche commented Oct 8, 2024

This doesn't appear to have worked as expected:

dotnet/sdk#43972

image

@mmitche
Copy link
Member Author

mmitche commented Oct 8, 2024

It may be that the check is actually neutral and not skipped

@premun
Copy link
Member

premun commented Oct 9, 2024

I guess we need to check the GitHub API response to see what is the actual value it returns

@premun
Copy link
Member

premun commented Oct 9, 2024

The GraphQL gives me this:

"checkRuns": {
  "nodes": [
    {
      "name": "sdk-unified-build",
      "status": "COMPLETED",
      "conclusion": "NEUTRAL"
    },
}

@premun
Copy link
Member

premun commented Oct 9, 2024

@mmitche are we worried that Neutral is also the state before we queue the check? I remember some worries like that so that the service does not merge stuff right away (though we do the 5 minute delay I believe after opening a PR now)

premun added a commit to premun/arcade-services that referenced this pull request Oct 9, 2024
@premun
Copy link
Member

premun commented Oct 9, 2024

#4026

@akoeplinger
Copy link
Member

Last time we did try to change the neutral state: #2997

@marcpopMSFT
Copy link
Member

Any more news here? Still affecting SDK PR checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants